Trying to run the x86 relocs tool on a BSD based HOSTCC (cross compilation environment) leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
and when cross compiling a MIPS kernel on a BSD based HOSTCC we get errors like
SYNC include/config/auto.conf.cmd - due to: .config egrep: empty (sub)expression UPD include/config/kernel.release HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that relocs.c on x86 uses patterns like
"something(|_end)"
while MIPS uses egrep with
(|MINOR_|PATCHLEVEL_)
In both cases it is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regcmp() or egrep implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Test Linux:
root@letux:~# echo foo | egrep '^(|foo)$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(|foo)$' root@letux:~# echo f | egrep '^(|foo)$' root@letux:~# echo | egrep '^(|foo)$'
root@letux:~# echo foo | egrep '^(foo)?$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(foo)?$' root@letux:~# echo f | egrep '^(foo)?$' root@letux:~# echo | egrep '^(foo)?$'
root@letux:~#
Test BSD:
iMac:master hns$ echo foo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo fool | egrep '^(foo)?$' egrep: empty (sub)expression iMac:master hns$ echo fun | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo f | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo foo | egrep '^(foo)?$' foo iMac:master hns$ echo fool | egrep '^(foo)?$' iMac:master hns$ echo fun | egrep '^(foo)?$' iMac:master hns$ echo f | egrep '^(foo)?$' iMac:master hns$ echo | egrep '^(foo)?$'
iMac:master hns$
H. Nikolaus Schaller (2): x86/tools/relocs: Fix non-POSIX regexp arch: mips: Fix non-POSIX regexp
arch/mips/Makefile | 2 +- arch/x86/tools/relocs.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
Trying to run a cross-compiled x86 relocs tool on a BSD based HOSTCC leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
It turns out that relocs.c uses patterns like
"something(|_end)"
This is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regexp() implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Fixes: fd952815307f ("x86-32, relocs: Whitelist more symbols for ld bug workaround") Signed-off-by: H. Nikolaus Schaller hns@goldelico.com --- arch/x86/tools/relocs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index 04c5a44b96827..9ba700dc47de4 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -57,12 +57,12 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = { [S_REL] = "^(__init_(begin|end)|" "__x86_cpu_dev_(start|end)|" - "(__parainstructions|__alt_instructions)(|_end)|" - "(__iommu_table|__apicdrivers|__smp_locks)(|_end)|" + "(__parainstructions|__alt_instructions)(_end)?|" + "(__iommu_table|__apicdrivers|__smp_locks)(_end)?|" "__(start|end)_pci_.*|" "__(start|end)_builtin_fw|" - "__(start|stop)___ksymtab(|_gpl)|" - "__(start|stop)___kcrctab(|_gpl)|" + "__(start|stop)___ksymtab(_gpl)?|" + "__(start|stop)___kcrctab(_gpl)?|" "__(start|stop)___param|" "__(start|stop)___modver|" "__(start|stop)___bug_table|"
When cross compiling a MIPS kernel on a BSD based HOSTCC leads to errors like
SYNC include/config/auto.conf.cmd - due to: .config egrep: empty (sub)expression UPD include/config/kernel.release HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that egrep uses this egrep pattern:
(|MINOR_|PATCHLEVEL_)
This is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux egrep implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Fixes: 48c35b2d245f ("[MIPS] There is no __GNUC_MAJOR__") Signed-off-by: H. Nikolaus Schaller hns@goldelico.com --- arch/mips/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile index 258234c35a096..674f68d16a73f 100644 --- a/arch/mips/Makefile +++ b/arch/mips/Makefile @@ -321,7 +321,7 @@ KBUILD_LDFLAGS += -m $(ld-emul)
ifdef CONFIG_MIPS CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \ - egrep -vw '__GNUC_(|MINOR_|PATCHLEVEL_)_' | \ + egrep -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \ sed -e "s/^#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/$$/&&/g') endif
Any chance that it gets merged?
Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller hns@goldelico.com:
Trying to run the x86 relocs tool on a BSD based HOSTCC (cross compilation environment) leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
and when cross compiling a MIPS kernel on a BSD based HOSTCC we get errors like
SYNC include/config/auto.conf.cmd - due to: .config egrep: empty (sub)expression UPD include/config/kernel.release HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that relocs.c on x86 uses patterns like
"something(|_end)"
while MIPS uses egrep with
(|MINOR_|PATCHLEVEL_)
In both cases it is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regcmp() or egrep implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Test Linux:
root@letux:~# echo foo | egrep '^(|foo)$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(|foo)$' root@letux:~# echo f | egrep '^(|foo)$' root@letux:~# echo | egrep '^(|foo)$'
root@letux:~# echo foo | egrep '^(foo)?$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(foo)?$' root@letux:~# echo f | egrep '^(foo)?$' root@letux:~# echo | egrep '^(foo)?$'
root@letux:~#
Test BSD:
iMac:master hns$ echo foo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo fool | egrep '^(foo)?$' egrep: empty (sub)expression iMac:master hns$ echo fun | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo f | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo foo | egrep '^(foo)?$' foo iMac:master hns$ echo fool | egrep '^(foo)?$' iMac:master hns$ echo fun | egrep '^(foo)?$' iMac:master hns$ echo f | egrep '^(foo)?$' iMac:master hns$ echo | egrep '^(foo)?$'
iMac:master hns$
H. Nikolaus Schaller (2): x86/tools/relocs: Fix non-POSIX regexp arch: mips: Fix non-POSIX regexp
arch/mips/Makefile | 2 +- arch/x86/tools/relocs.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
-- 2.31.1
+ Masahiro, linux-kbuild (EOM)
On Mon, Jul 19, 2021 at 12:07 PM H. Nikolaus Schaller hns@goldelico.com wrote:
Any chance that it gets merged?
Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller hns@goldelico.com:
Trying to run the x86 relocs tool on a BSD based HOSTCC (cross compilation environment) leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
and when cross compiling a MIPS kernel on a BSD based HOSTCC we get errors like
SYNC include/config/auto.conf.cmd - due to: .config egrep: empty (sub)expression UPD include/config/kernel.release HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that relocs.c on x86 uses patterns like
"something(|_end)"
while MIPS uses egrep with
(|MINOR_|PATCHLEVEL_)
In both cases it is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regcmp() or egrep implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Test Linux:
root@letux:~# echo foo | egrep '^(|foo)$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(|foo)$' root@letux:~# echo f | egrep '^(|foo)$' root@letux:~# echo | egrep '^(|foo)$'
root@letux:~# echo foo | egrep '^(foo)?$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(foo)?$' root@letux:~# echo f | egrep '^(foo)?$' root@letux:~# echo | egrep '^(foo)?$'
root@letux:~#
Test BSD:
iMac:master hns$ echo foo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo fool | egrep '^(foo)?$' egrep: empty (sub)expression iMac:master hns$ echo fun | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo f | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo foo | egrep '^(foo)?$' foo iMac:master hns$ echo fool | egrep '^(foo)?$' iMac:master hns$ echo fun | egrep '^(foo)?$' iMac:master hns$ echo f | egrep '^(foo)?$' iMac:master hns$ echo | egrep '^(foo)?$'
iMac:master hns$
H. Nikolaus Schaller (2): x86/tools/relocs: Fix non-POSIX regexp arch: mips: Fix non-POSIX regexp
arch/mips/Makefile | 2 +- arch/x86/tools/relocs.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
-- 2.31.1
Hi all, any chance to get that reviewed and merged into v5.15-rc1 and backported to stable? Thank you, Nikolaus Schaller
Am 19.07.2021 um 22:37 schrieb Nick Desaulniers ndesaulniers@google.com:
- Masahiro, linux-kbuild (EOM)
On Mon, Jul 19, 2021 at 12:07 PM H. Nikolaus Schaller hns@goldelico.com wrote:
Any chance that it gets merged?
Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller hns@goldelico.com:
Trying to run the x86 relocs tool on a BSD based HOSTCC (cross compilation environment) leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
and when cross compiling a MIPS kernel on a BSD based HOSTCC we get errors like
SYNC include/config/auto.conf.cmd - due to: .config egrep: empty (sub)expression UPD include/config/kernel.release HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that relocs.c on x86 uses patterns like
"something(|_end)"
while MIPS uses egrep with
(|MINOR_|PATCHLEVEL_)
In both cases it is not valid syntax or gives undefined results according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regcmp() or egrep implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Test Linux:
root@letux:~# echo foo | egrep '^(|foo)$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(|foo)$' root@letux:~# echo f | egrep '^(|foo)$' root@letux:~# echo | egrep '^(|foo)$'
root@letux:~# echo foo | egrep '^(foo)?$' foo root@letux:~# echo fool | egrep '^(foo)?$' root@letux:~# echo fun | egrep '^(foo)?$' root@letux:~# echo f | egrep '^(foo)?$' root@letux:~# echo | egrep '^(foo)?$'
root@letux:~#
Test BSD:
iMac:master hns$ echo foo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo fool | egrep '^(foo)?$' egrep: empty (sub)expression iMac:master hns$ echo fun | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo f | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo | egrep '^(|foo)$' egrep: empty (sub)expression iMac:master hns$ echo foo | egrep '^(foo)?$' foo iMac:master hns$ echo fool | egrep '^(foo)?$' iMac:master hns$ echo fun | egrep '^(foo)?$' iMac:master hns$ echo f | egrep '^(foo)?$' iMac:master hns$ echo | egrep '^(foo)?$'
iMac:master hns$
H. Nikolaus Schaller (2): x86/tools/relocs: Fix non-POSIX regexp arch: mips: Fix non-POSIX regexp
arch/mips/Makefile | 2 +- arch/x86/tools/relocs.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
-- 2.31.1
-- Thanks, ~Nick Desaulniers